This PR replaces dash and s with builtin packages or magit dependencies#208
Open
Thaodan wants to merge 3 commits intoalphapapa:masterfrom
Open
This PR replaces dash and s with builtin packages or magit dependencies#208Thaodan wants to merge 3 commits intoalphapapa:masterfrom
Thaodan wants to merge 3 commits intoalphapapa:masterfrom
Conversation
Replace dash with builtin packages and llama. This change follows Magit's changes to replace dash. Most function could be replaced by their seq or subr-x dropin replacements. Some function calls could be simplified by calling seq-filter directly instead of using the `(-non-nill)' function, the seq equivalent is seq-filter #'identify LIST. Some used the local it binding from dash which could be replaced quite easily with the `##' macro provided by llama. llama is a new dependency but it is also pulled in Magit.
when-let was added in Emasc 25.1, when-let* in Emacs 26.1. Minimum Emacs version is 26.1 so that should be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces dash and s with builtin functions.
For the one case where dash would have been still needed use llama.
Note that this PR raises the minimum Emacs version to 28.1 but Magit's current minimum Emacs
version is the same.